Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): Add @fern-api/ir-generator-tests #5291

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

amckinney
Copy link
Contributor

This splits out the tests included in the @fern-api/ir-generator package into @fern-api/ir-generator-tests (to mirror the same setup seen in openapi-ir-to-fern-tests.

With this, we're able to remove the following dependencies from @fern-api/ir-generator entirely:

  1. @fern-api/project-loader
  2. @fern-api/workspace-loader

These dependencies were only used in tests, but moving things around makes it far easier to understand whether or not a package remains browser compatible (i.e. by simply viewing the package.json dependencies).

@amckinney amckinney requested a review from dsinghvi as a code owner November 27, 2024 17:45
Copy link

@amckinney amckinney merged commit 399772a into main Nov 27, 2024
48 of 51 checks passed
@amckinney amckinney deleted the amckinney/ir-generator-tests branch November 27, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants